Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the otel ErrorHandler for handling errors. #196

Merged
merged 6 commits into from
Jul 27, 2021
Merged

Use the otel ErrorHandler for handling errors. #196

merged 6 commits into from
Jul 27, 2021

Conversation

dashpole
Copy link
Contributor

Fixes #189.

This also unexports the field in options that contains the error handler.

@dashpole dashpole requested a review from punya July 20, 2021 22:29
@punya
Copy link
Contributor

punya commented Jul 27, 2021

@dashpole would you mind resolving conflicts?

punya
punya reviewed Jul 27, 2021
View reviewed changes
exporter/trace/trace.go Outdated Show resolved Hide resolved
@punya punya merged commit bd41621 into GoogleCloudPlatform:main Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@punya punya punya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use opentelemetry-go's error handling for the trace exporter
2 participants
@dashpole @punya